On Mon, Nov 10, 2014 at 8:04 PM, Johan Herland <jo...@herland.net> wrote: > On Mon, Nov 10, 2014 at 9:42 PM, Junio C Hamano <gits...@pobox.com> wrote: >> Johan Herland <jo...@herland.net> writes: >> >>> Make this test script appear somewhat less old-fashioned: >>> - Use test helper functions: >>> - write_script >>> - test_commit >>> - test_write_lines >>> - test_config >>> - test_unconfig >>> - test_path_is_missing >>> - Remove whitespace between redirection operators and their targets. >>> - Move preparation of "except" files into tests. >> >> expect, I think (no need to resend; I've fixed it up locally). > > Thanks.
One further modernization would be to use the name "actual" rather than "output" for files holding actual contents (as opposed to the "expect" contents). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
