On Wed, May 25, 2016 at 3:38 PM, Junio C Hamano <[email protected]> wrote: > Stefan Beller <[email protected]> writes: > >> Sometimes the history of a submodule is not considered important by >> the projects upstream. To make it easier for downstream users, allow >> a field 'submodule.<name>.depth' in .gitmodules, which can be used >> to indicate the recommended depth. > > Hmph. I can understand and certainly agree with the first sentence, > but I am not sure if "depth", if it is anything other than "1" or > "infinity", is a reasonable value. > > I'd understand if a project wants to say something like "at this > moment, history before v2.0 tag does not matter", though.
I fell for the trap, like all depth related problems fall into. I came up with the easiest solution to be implemented into Git, not what the user actually wants. Background for this change is trying to get a similar thing like the "clone-depth" field from repo manifests implemented into Git. And looking at e.g. [1], this is either non existent (infinity) or 1. So maybe instead of giving a depth recommendation in the .gitmodules, we only fill in a boolean config "[non]shallow" which defaults to non shallow in case of not giving the field. Thanks, Stefan [1] https://android.googlesource.com/platform/manifest/+/master/default.xml -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
