On 06/01/2016 02:12 AM, David Turner wrote:
> On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
>> +struct dir_iterator_level {
>> +    int initialized;
>> +
>> +    DIR *dir;
>> +
>> +    /*
>> +     * The length of the directory part of refname at this level
> 
> 
> "refname"? Isn't this was for directories?

Thanks.

>> +                    if (lstat(iter->base.path.buf, &iter
> ->base.st) < 0)
>> +                            continue; /* silently skip */
> 
> Should we warn on non-ENOENT errors here?

Good idea. I'll add that.

>> +/*
>> + * End the iteration before it has been exhausted. Free the
>> reference
> 
> s/reference/directory/

Thanks. Will fix.

Michael

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to