clebertsuconic commented on code in PR #4192:
URL: https://github.com/apache/activemq-artemis/pull/4192#discussion_r957290523
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1797,6 +1797,11 @@ private DuplicateCheckResult
checkBridgeDuplicateID(final Message message,
message.usageDown(); // this will cause large message delete
return DuplicateCheckResult.DuplicateNotStartedTX;
}
+ final byte[] duplicateIDBytes = message.getDuplicateIDBytes();
Review Comment:
this was "not done" on purpose...
Say the sender is sending messages.... you failed and reconnected...
the next time you send a message, the operation will then succeed or fail
based on the previous cache.
now if you start to fill up the cache in the absence of the producer
connected to that node, you are kind of breaking that concept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
