AntonRoskvist commented on code in PR #4192:
URL: https://github.com/apache/activemq-artemis/pull/4192#discussion_r957610393
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1797,6 +1797,11 @@ private DuplicateCheckResult
checkBridgeDuplicateID(final Message message,
message.usageDown(); // this will cause large message delete
return DuplicateCheckResult.DuplicateNotStartedTX;
}
+ final byte[] duplicateIDBytes = message.getDuplicateIDBytes();
Review Comment:
Again, not saying this should be merged, but I guess the confusing thing
here is that we are referring to two separate things as the same:
"Regular" duplicateCache - circular record of every message that has passed
an address
"Bridge/cluster duplicateCache" - Special cache used on bridged destinations
to handle redistribution/redeliveries etc
From what I can tell they serve separate purposes and as such they should
not interfere with each other.
If so, it's fair to assume the "useDuplicateDetection" property on a bridge
should only use and consider it's own cache.
So... when does it make sense to populate the address-level cache? Is an
external producer required or does it get populated by things like
import/export, scaling or management operations for instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
