franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis
deadlock using MQTT Protocol
URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264370764
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -210,6 +211,9 @@
private final Runnable deliverRunner = new DeliverRunner();
+ //This lock is used to prevent deadlocks between direct and async deliveries
+ private final ReentrantLock deliverLock = new ReentrantLock();
Review comment:
Not sure: I have made explicit an implicit requirement. And now the order of
locking is ensured just into QueueImpl , while before it was enforced in
different classes (callbacks, transactions and queue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
