franz1981 commented on a change in pull request #2577: ARTEMIS-1604 Artemis
deadlock using MQTT Protocol
URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264402128
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -249,7 +253,7 @@
private volatile boolean directDeliver = true;
- private volatile boolean supportsDirectDeliver = true;
+ private volatile boolean supportsDirectDeliver = false;
Review comment:
@clebertsuconic has proposed this change, to avoid having a small window in
which a protocol that isn't suporting directDelivery could attempt to do one
due to a race while adding its consumers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
