michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 
implement duplicate detection for AMQP
URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272321577
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
 ##########
 @@ -971,7 +971,7 @@ public Object getAMQPUserID() {
 
    @Override
    public Object getDuplicateProperty() {
-      return null;
+      return 
getObjectProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID);
 
 Review comment:
   I dont know if its amqp specific. I just know they do it by message id, 
which is a more agnostic to vendor field.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to