michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294
implement duplicate detection for AMQP
URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272542023
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -971,7 +971,7 @@ public Object getAMQPUserID() {
@Override
public Object getDuplicateProperty() {
- return null;
+ return
getObjectProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID);
Review comment:
agreed nope, no precludement. It was more a query if there was any form of
standard, i assumed maybe there was based on azure having same feature. But if
there isn't and its vendor specific there. Then for now we just have to be
vendor specific to our keys too. +1 this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
