michaelandrepearce commented on a change in pull request #2623: ARTEMIS-2309
TempQueueCleanerUpper instances are leaking
URL: https://github.com/apache/activemq-artemis/pull/2623#discussion_r275986571
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
##########
@@ -153,7 +153,7 @@
protected volatile boolean started = false;
- protected final Map<SimpleString, TempQueueCleanerUpper>
tempQueueCleannerUppers = new HashMap<>();
+ protected static final Map<SimpleString, TempQueueCleanerUpper>
tempQueueCleannerUppers = new HashMap<>();
Review comment:
As temp dest are tied to the connection should maybe the map live there and
shared on all sessions on that connection. Thus removing the static but also
being correct with regards to being able to share between sessions on same
connection. And also scoping them to the connection which is according to the
original jira what theyre meant to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
