michaelandrepearce commented on a change in pull request #2623: ARTEMIS-2309
TempQueueCleanerUpper instances are leaking
URL: https://github.com/apache/activemq-artemis/pull/2623#discussion_r275992541
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
##########
@@ -153,7 +153,7 @@
protected volatile boolean started = false;
- protected final Map<SimpleString, TempQueueCleanerUpper>
tempQueueCleannerUppers = new HashMap<>();
+ protected static final Map<SimpleString, TempQueueCleanerUpper>
tempQueueCleannerUppers = new HashMap<>();
Review comment:
I put comment on your pr to justins.
Essentially what about other protocols...doing it in connection and
serversession server side means it does same for them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
