michaelandrepearce commented on a change in pull request #2625: ARTEMIS-2306
Make group first off by default, unless configured
URL: https://github.com/apache/activemq-artemis/pull/2625#discussion_r276185777
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageGroupsTest.java
##########
@@ -53,6 +55,13 @@ protected String getConfiguredProtocols() {
return "AMQP,OPENWIRE,CORE";
}
+ @Override
+ protected void configureAddressPolicy(ActiveMQServer server) {
+ super.configureAddressPolicy(server);
+ AddressSettings addressSettings =
server.getConfiguration().getAddressesSettings().get("#");
Review comment:
Thats because all the tests are testing that functionality currently. re
negative test case, though what are you testing, as you wont have a key to look
for / test if it is present or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services