michaelandrepearce commented on a change in pull request #2625: ARTEMIS-2306
Make group first off by default, unless configured
URL: https://github.com/apache/activemq-artemis/pull/2625#discussion_r276195633
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageGroupsTest.java
##########
@@ -53,6 +55,13 @@ protected String getConfiguredProtocols() {
return "AMQP,OPENWIRE,CORE";
}
+ @Override
+ protected void configureAddressPolicy(ActiveMQServer server) {
+ super.configureAddressPolicy(server);
+ AddressSettings addressSettings =
server.getConfiguration().getAddressesSettings().get("#");
Review comment:
Ok have made it so we have a specific address-setting where we turn it ON.
And re-factored tests, so we now
Test with non-prefixed address where it should be OFF by default, and check
the property isnt there.
And then a separate test where we use an address which is prefixed and
matches the ON address setting, and test the property is there for the first
message, and not for others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
