ldebello commented on issue #2634: ARTEMIS-2316 AMQPMessage missing ApplicationProperties from custom transformer URL: https://github.com/apache/activemq-artemis/pull/2634#issuecomment-485896538 @michaelandrepearce I was not aware of that usecase, my code does not check for null so that is an issue, but I don't how you handle regressions in this case, the original behaviour was reencode and that was change in 2.6.4, it was a side effect of an improvement in performance but the behaviour was there. Imaging our use case moving from 2.6.3 to 2.6.4 and getting this error nobody expects this kind of changes in a patch release. Also if you see the test AddHeadersTransformer it is adding properties but not calling reencode() so at least we should document this requirement in docs and in the code as well
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
