ldebello commented on issue #2634: ARTEMIS-2316 AMQPMessage missing ApplicationProperties from custom transformer URL: https://github.com/apache/activemq-artemis/pull/2634#issuecomment-485903616 > It should be noted here, application properties in AMQP are not meant to be modified, so you're breaking spec in doing that. This is fine for your custom transformer to do that but then you need to handle that in your transformer, especially as there could be introduced concurrency issues (thus safer to make copy first) if modifying the underlying shared message... which i would be cautious of adding to main broker. I think that should explicit in docs and also in the tests and as I mentioned the test that you can find in the code is not doing that AddHeadersTransformer. also breaking that in a patch is like something unexpected, so I dont agree with custom transformer responsability at least for 2.6.4 it does not make sense.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
