gemmellr commented on issue #2655: ARTEMIS-2327 ExceptionListener invoked when connection level exception URL: https://github.com/apache/activemq-artemis/pull/2655#issuecomment-488263475 Something else doing something isnt necessarily a reason to copy it. The async is in reference to the application not having already been told synchronously via a method call, which as above the spec doc is clear on. As I said, it perhaps depends what the exception is, and what reaction is being taken to it. If this exception always represents the connections ultimate failure and isnt in response to a particular method call then telling the exception listener does seem reasonable. If it doesnt, e.g its failing over, or its only a single methods failure and everythign else is fine, then it often might not be appropriate. In particular the async ExceptionListener is good for things only using MessageListeners, which will never find out otherwise since they dont call methods [if theres no delivery happening]. Spring uses synchronous receive calls (by default at least) so it should already discover failures that result in the connection being considered broken, without the ExceptionListener. If it doesnt that might point to another issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
