gemmellr commented on issue #2655: ARTEMIS-2327 ExceptionListener invoked when connection level exception URL: https://github.com/apache/activemq-artemis/pull/2655#issuecomment-488264798 Didnt see most of your edits when replying earlier, but my reply essentially fits anyway. I havent looked at and am not familiar with the client code outside the context of this diff. I'm just saying 'always call the exception listener' for connection exceptions seems out of line with the specs general desire, except perhaps if those exceptions are always classed as connection-ending failures, or if the surrounding code such as the failover stuff is intercepting and handling that, in which case ok.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
