clebertsuconic commented on a change in pull request #2647: ARTEMIS-2323
NettyTransport should also send requests with void promises
URL: https://github.com/apache/activemq-artemis/pull/2647#discussion_r282203050
##########
File path:
tests/artemis-test-support/src/main/java/org/apache/activemq/transport/netty/NettyTransport.java
##########
@@ -38,6 +38,8 @@
ByteBuf allocateSendBuffer(int size) throws IOException;
+ void sendVoidPromise(ByteBuf output) throws IOException;
Review comment:
I'm trying to understand why we would need a send with and without promise.
It seems to be all we need is to change send to be with a void promise.
please advise?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
