clebertsuconic commented on a change in pull request #2647: ARTEMIS-2323 
NettyTransport should also send requests with void promises
URL: https://github.com/apache/activemq-artemis/pull/2647#discussion_r282221591
 
 

 ##########
 File path: 
tests/artemis-test-support/src/main/java/org/apache/activemq/transport/netty/NettyWSTransport.java
 ##########
 @@ -80,16 +80,13 @@ public NettyWSTransport(NettyTransportListener listener, 
URI remoteLocation, Net
    }
 
    @Override
-   public ChannelFuture send(ByteBuf output) throws IOException {
-      checkConnected();
-      int length = output.readableBytes();
-      if (length == 0) {
-         return null;
-      }
-
-      LOG.trace("Attempted write of: {} bytes", length);
 
 Review comment:
   I don't think this one is very useful...
   
   I will merge it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to