franz1981 commented on a change in pull request #2681: ARTEMIS-2308 Support
exporting metrics
URL: https://github.com/apache/activemq-artemis/pull/2681#discussion_r287791413
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
##########
@@ -101,19 +103,19 @@
@Attribute(desc = "names of all bindings (both queues and diverts) bound to
this address")
String[] getBindingNames() throws Exception;
- @Attribute(desc = "number of messages added to all the queues for this
address")
+ @Attribute(desc = "number of messages currently in all queues bound to this
address (includes scheduled, paged, and in-delivery messages)")
Review comment:
why no refactor this `desc` as you've done for the others? eg
`ROUTED_MESSAGE_COUNT_DESCRIPTION`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
