franz1981 commented on a change in pull request #2681: ARTEMIS-2308 Support exporting metrics URL: https://github.com/apache/activemq-artemis/pull/2681#discussion_r287824974
########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.activemq.artemis.core.server.metrics; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.ToDoubleFunction; + +import io.micrometer.core.instrument.Gauge; +import io.micrometer.core.instrument.Meter; +import io.micrometer.core.instrument.MeterRegistry; +import io.micrometer.core.instrument.Metrics; +import io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics; +import org.apache.activemq.artemis.api.core.management.ResourceNames; +import org.apache.activemq.artemis.core.server.ActiveMQServerLogger; + +public class MetricsManager { Review comment: That's a huge comment; API change proposal... ```java private final String brokerName; private final MeterRegistry meterRegistry; private final Map<String, List<Meter>> meters = new ConcurrentHashMap<>(); public MetricsManager(String brokerName, ActiveMQMetricsPlugin metricsPlugin) { this.brokerName = brokerName; meterRegistry = metricsPlugin.getRegistry(); Metrics.globalRegistry.add(meterRegistry); new JvmMemoryMetrics().bindTo(meterRegistry); } public MeterRegistry getMeterRegistry() { return meterRegistry; } @FunctionalInterface public interface MetricGaugeBuilder { void register(String metricName, Object state, ToDoubleFunction f, String description); } public void registerQueueGauge(String address, String queue, Consumer<MetricGaugeBuilder> builder) { final MeterRegistry meterRegistry = this.meterRegistry; if (meterRegistry == null) { return; } final List<Gauge.Builder> newMeters = new ArrayList<>(); builder.accept((metricName, state, f, description) -> { Gauge.Builder meter = Gauge.builder("artemis." + metricName, state, f).tag("broker", brokerName).tag("address", address).tag("queue", queue).description(description); newMeters.add(meter); }); final String resource = ResourceNames.QUEUE + queue; this.meters.compute(resource, (s, meters) -> { //the old meters are ignored on purpose meters = new ArrayList<>(newMeters.size()); for (Gauge.Builder gauge : newMeters) { meters.add(gauge.register(meterRegistry)); } return meters; }); } public void registerAddressGauge(String address, Consumer<MetricGaugeBuilder> builder) { final MeterRegistry meterRegistry = this.meterRegistry; if (meterRegistry == null) { return; } final List<Gauge.Builder> newMeters = new ArrayList<>(); builder.accept((metricName, state, f, description) -> { Gauge.Builder meter = Gauge.builder("artemis." + metricName, state, f).tag("broker", brokerName).tag("address", address).description(description); newMeters.add(meter); }); final String resource = ResourceNames.ADDRESS + address; this.meters.compute(resource, (s, meters) -> { //the old meters are ignored on purpose meters = new ArrayList<>(newMeters.size()); for (Gauge.Builder gauge : newMeters) { meters.add(gauge.register(meterRegistry)); } return meters; }); } public void registerBrokerGauge(Consumer<MetricGaugeBuilder> builder) { final MeterRegistry meterRegistry = this.meterRegistry; if (meterRegistry == null) { return; } final List<Gauge.Builder> newMeters = new ArrayList<>(); builder.accept((metricName, state, f, description) -> { Gauge.Builder meter = Gauge.builder("artemis." + metricName, state, f).tag("broker", brokerName).description(description); newMeters.add(meter); }); final String resource = ResourceNames.BROKER + "." + brokerName; this.meters.compute(resource, (s, meters) -> { //the old meters are ignored on purpose meters = new ArrayList<>(newMeters.size()); for (Gauge.Builder gauge : newMeters) { meters.add(gauge.register(meterRegistry)); } return meters; }); } public void remove(String component) { meters.computeIfPresent(component, (s, meters) -> { if (meters == null) { return null; } for (Meter meter : meters) { Meter removed = meterRegistry.remove(meter); if (ActiveMQServerLogger.LOGGER.isDebugEnabled()) { ActiveMQServerLogger.LOGGER.debug("Removed meter: " + removed.getId()); } } return null; }); } ``` That could be used with: ```java if (server != null && server.getMetricsManager() != null) { server.getMetricsManager().registerQueueGauge(queueName, addressName, builder -> { builder.register("message.count", pendingMetrics, metrics -> Double.valueOf(pendingMetrics.getMessageCount()), QueueControl.MESSAGE_COUNT_DESCRIPTION); builder.register(//...other useful metrics ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
