michaelpearce-gain commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r304252848
########## File path: test/nms-openwire-test.csproj ########## @@ -0,0 +1,66 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>netcoreapp2.2</TargetFramework> Review comment: true, and thats down to if we want to publish it to nuget at part of release, but still good to have uniform setup across them all, then its just down to should we wish to publish or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
