michaelpearce-gain commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r304255710
########## File path: src/nms-openwire.csproj ########## @@ -0,0 +1,44 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>netstandard2.0</TargetFramework> + <RootNamespace>Apache.NMS.ActiveMQ</RootNamespace> + <AssemblyName>Apache.NMS.ActiveMQ</AssemblyName> + <Version>1.8.0</Version> + <Company>Apache Software Foundation</Company> + <Product>Apache ActiveMQ</Product> + <Description>Apache NMS (.Net Standard Messaging Library): Openwire implementation of Apache NMS API</Description> + <Copyright>Copyright (C) 2005-2019 Apache Software Foundation</Copyright> + <PackageLicenseFile>LICENSE.txt</PackageLicenseFile> + <PackageProjectUrl>https://activemq.apache.org/components/nms/</PackageProjectUrl> + <PackageIconUrl>https://activemq.apache.org/assets/img/activemq_logo_icon.png</PackageIconUrl> + <RepositoryUrl>https://github.com/apache/activemq-nms-openwire</RepositoryUrl> + <RepositoryType>git</RepositoryType> + <PackageTags>apache;activemq;nms;api;net;messaging</PackageTags> + <SignAssembly>true</SignAssembly> + <AssemblyOriginatorKeyFile>NMSKey.snk</AssemblyOriginatorKeyFile> + <GeneratePackageOnBuild>true</GeneratePackageOnBuild> + <Authors>Apache ActiveMQ</Authors> + </PropertyGroup> + + <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'"> + <OutputPath>..\..\build\</OutputPath> + </PropertyGroup> + + <ItemGroup> + <Content Include="..\LICENSE.txt" Link="LICENSE.txt" /> + <Content Include="..\NOTICE.txt" Link="NOTICE.txt" /> + </ItemGroup> + + <ItemGroup> + <PackageReference Include="Apache.NMS" Version="1.8.0" /> + </ItemGroup> + + <ItemGroup> + <None Include="..\..\activemq-nms-api\LICENSE.txt"> Review comment: You need to create License and Notice files in this project (if exist probably need updating as i had to in API) and then point to them inside. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
