brusdev commented on a change in pull request #2759: ARTEMIS-2408 Too many
opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2759#discussion_r305239159
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1269,6 +1269,8 @@ void stop(boolean failoverOnServerShutdown, final
boolean criticalIOError, boole
this.analyzer = null;
}
+ activateCallbacks.clear();
Review comment:
Each time the server starts, it register a new activateCallback for
FileLockNodeManager and for ManagementServiceImpl. After n stop and start
without `activateCallbacks.clear();` the server has n activateCallback for
FileLockNodeManager and n activateCallback for ManagementServiceImpl. After
second start setUpServerLockFile is also called on previous activateCallbacks
causing file leaks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
