brusdev commented on a change in pull request #2759: ARTEMIS-2408 Too many
opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2759#discussion_r305262239
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1269,6 +1269,8 @@ void stop(boolean failoverOnServerShutdown, final
boolean criticalIOError, boole
this.analyzer = null;
}
+ activateCallbacks.clear();
Review comment:
@michaelandrepearce I see your point, we could replace
`activateCallbacks.clear();` with a call to unregisterActivateCallback on
LiveOnlyActivation.close for FileLockNodeManager and a call to
unregisterActivateCallback on ManagementServiceImpl.stop for
ManagementServiceImpl, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
