brusdev commented on a change in pull request #2741: ARTEMIS-2415 JDBCJournal
miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r305577281
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
##########
@@ -268,6 +271,8 @@ private boolean internalStop(boolean ioCriticalError,
boolean sendFailover) thro
idGenerator.persistCurrentID();
}
+ deletingLargeMessageTasks.await(30, TimeUnit.SECONDS);
Review comment:
I see your point but it normally should not block and 10 lines forward I see
the same code:
> latch.await(30, TimeUnit.SECONDS);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
