brusdev commented on a change in pull request #2741: ARTEMIS-2415 JDBCJournal 
miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r300657834
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ##########
 @@ -86,6 +87,8 @@
 
    protected ReplicationManager replicator;
 
+   protected final AtomicInteger deletingLargeMessageTasks = new 
AtomicInteger(0);
 
 Review comment:
   TBH, I can't reproduce the issue on JournalStorageManager/JournalImpl but in 
theory they should have the same issue of 
JDBCJournalStorageManager/JDBCJournalImpl. I think the issue on 
JournalStorageManager/JournalImpl is hidden by better performances.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to