wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering
message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r319814668
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -319,6 +321,8 @@
*/
private final Object directDeliveryGuard = new Object();
+ private final ConcurrentHashSet<String> lingerSessionIds = new
ConcurrentHashSet<>();
Review comment:
Closing ServerSession will roll back transaction. And I add synchronized
transaction block to avoid adding session ids when transaction is
rollbacking/committing. This is what ServerSessionImpl::addLingerConsumer
does(synchronizing access by this and afterCommit/afterRollback).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
