wy96f commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering 
message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r319916952
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -1567,6 +1581,10 @@ public long getDurableScheduledSize() {
       return scheduledDeliveryHandler.getScheduledReferences();
    }
 
+   private String getSessionManagementString(ServerSession serverSession) {
 
 Review comment:
   I copied code from Consumer::toManagementString. Do you mean using 
StringBuilder? It sounds not a hot path here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to