michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323926285
##########
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##########
@@ -55,16 +55,19 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
- case MessageSupport.JMS_TYPE_BYTE:
- return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
- case MessageSupport.JMS_TYPE_OBJ:
- return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+ case MessageSupport.JMS_TYPE_BYTE:
+ // Java serialized objects should be treated as bytes
messages
+ // as we cannot deserialize them in .NET world
+ case MessageSupport.JMS_TYPE_OBJ when
IsContentType(SymbolUtil.SERIALIZED_JAVA_OBJECT_CONTENT_TYPE,
GetContentType(message.Properties)):
Review comment:
that way imagine someone made a XMS impl for AMQP where X = some other lang,
then you dont need worry, as you only handle where its positively the
serialized type you can support which is .net varient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
