michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928933
##########
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##########
@@ -55,16 +55,26 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
- case MessageSupport.JMS_TYPE_BYTE:
- return new AmqpNmsBytesMessageFacade();
case MessageSupport.JMS_TYPE_TXT:
return new AmqpNmsTextMessageFacade();
- case MessageSupport.JMS_TYPE_OBJ:
- return new AmqpNmsObjectMessageFacade();
case MessageSupport.JMS_TYPE_STRM:
return new AmqpNmsStreamMessageFacade();
case MessageSupport.JMS_TYPE_MAP:
return new AmqpNmsMapMessageFacade();
+ case MessageSupport.JMS_TYPE_BYTE:
+ return new AmqpNmsBytesMessageFacade();
+ case MessageSupport.JMS_TYPE_OBJ:
+ {
+ Symbol contentType =
GetContentType(message.Properties);
+ if
(IsContentType(SymbolUtil.SERIALIZED_DOTNET_OBJECT_CONTENT_TYPE, contentType)
|| contentType == null)
Review comment:
Can we remove the Serialized_java_object_content_type static in SymbolUtil
now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
