michaelandrepearce commented on a change in pull request #44: AMQNET-620: Initialize ConnectionFactory properly with System.Uri overload URL: https://github.com/apache/activemq-nms-amqp/pull/44#discussion_r331731333
########## File path: src/NMS.AMQP/NmsConnectionFactory.cs ########## @@ -58,7 +58,7 @@ public NmsConnectionFactory(string brokerUri) public NmsConnectionFactory(Uri brokerUri) { - this.brokerUri = brokerUri; + this.BrokerUri = brokerUri; Review comment: Nit. But so is consistent with other constructors can the "this" be removed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services