michaelandrepearce commented on a change in pull request #42: AMQNET-619:
Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331731380
##########
File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
##########
@@ -53,13 +53,13 @@ public Task Attach()
};
string linkName = info.Id + ":" + target.Address;
- var taskCompletionSource = new TaskCompletionSource<bool>();
- senderLink = new SenderLink(session.UnderlyingSession, linkName,
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+ var tsc = new TaskCompletionSource<bool>();
Review comment:
Can you revert the shortening of the var. Unneeded change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
