clebertsuconic commented on a change in pull request #2897: ARTEMIS-2558 Add
the commented out args to dump the java heap on OOME
URL: https://github.com/apache/activemq-artemis/pull/2897#discussion_r357662839
##########
File path:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile
##########
@@ -41,6 +41,11 @@ JAVA_ARGS="${java-opts} -XX:+PrintClassHistogram
-XX:+UseG1GC -Xms512M -Xmx2G -D
# Replace "all_pauses.log" with the file name you want to log to.
# JAVA_ARGS="$JAVA_ARGS -XX:+PrintSafepointStatistics
-XX:PrintSafepointStatisticsCount=1 -XX:+PrintGCApplicationStoppedTime
-XX:+PrintGCApplicationConcurrentTime -XX:+LogVMOutput
-XX:LogFile=all_pauses.log"
+#
+# Enables the dumping of the java heap to the file oom_dump.hprof by using the
heap profiler (HPROF)
+# when a java.lang.OutOfMemoryError exception is thrown.
+# JAVA_ARGS="$JAVA_ARGS -XX:+HeapDumpOnOutOfMemoryError
-XX:HeapDumpPath=${ARTEMIS_INSTANCE}/log/oom_dump.hprof"
Review comment:
timestamp would be generated based on when the broker started on this case..
not when the dump happened...
I would keep it simple here.
If you want a variable name.. fine.. but other than that... you start the
broker now.. it dumps 5 months from now.. the timestamp is useless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
