michaelandrepearce commented on a change in pull request #2903: ARTEMIS-2565 -
Add plugin support for Federated Queues/Addresses
URL: https://github.com/apache/activemq-artemis/pull/2903#discussion_r357892929
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/FederatedQueueConsumer.java
##########
@@ -163,11 +181,29 @@ private void disconnect() throws ActiveMQException {
@Override
public void onMessage(ClientMessage clientMessage) {
try {
+ if (server.hasBrokerFederationPlugins()) {
+ try {
+ server.callBrokerFederationPlugins(plugin ->
plugin.beforeFederatedQueueConsumerMessageHandled(this, clientMessage));
+ } catch (ActiveMQException t) {
+ logger.warn("Error executing
beforeFederatedQueueConsumerMessageHandled plugin method: {}", t.getMessage(),
t);
Review comment:
should be a logger with code, e.g. explicit method logger with code as at
warn (same for all logger.warns in this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
