michaelandrepearce commented on a change in pull request #2903: ARTEMIS-2565 -
Add plugin support for Federated Queues/Addresses
URL: https://github.com/apache/activemq-artemis/pull/2903#discussion_r357893031
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/FederationStream.java
##########
@@ -106,4 +107,25 @@ public int getPriorityAdjustment() {
return config.getConnectionConfiguration().getPriorityAdjustment();
}
+ protected void callFederationStreamStartedPlugins() {
+ if (server.hasBrokerFederationPlugins()) {
+ try {
+ server.callBrokerFederationPlugins(plugin ->
plugin.federationStreamStarted(this));
Review comment:
If we are going to pass this to the plugin, we should extract interface, and
method of federationStreamStarted should take the interface, not the
implementation. As plugin should just have api's, else will cause issues in any
future refactor (like you had done in last pr)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
