franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save
Message decoding when unnecessary
URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369697534
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
##########
@@ -372,6 +372,79 @@ private synchronized void
forEachInternal(BiConsumer<SimpleString, PropertyValue
}
}
+ /**
+ * Performs a search among the valid key properties contained in {@code
buffer}, starting from {@code from}
+ * assuming it to be a valid encoded {@link TypedProperties} content.
+ *
+ * @throws IllegalStateException if any not-valid property is found while
searching the {@code key} property
+ */
+ public static boolean searchProperty(SimpleString key, ByteBuf buffer, int
startIndex) {
Review comment:
Re your comments
> You're still parsing the key at its exact position.
It's comparing, but it's not parsing (there is no decoding involved).
In additon, to compare `SimpleString` and `ByteBuf` is using another
optimized method I've implemented some time ago that allow to compare them very
quickly directly ie
https://github.com/apache/activemq-artemis/blob/0293d8057441e6bfeb9e6533774862ffc86d74eb/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java#L346-L360
> in Java every time you do buffer.getInt(index) you will create a few bytes
in memory.
That's the signature of the Netty method:
https://netty.io/4.0/api/io/netty/buffer/ByteBuf.html#getInt-int-
it would return a primitive `int`: it's not allocating anything. I've taken
care to design that method to be garbage-free :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
