franz1981 edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-580207415 @michaelandrepearce @clebertsuconic I've added some tests and this is ready to get a full review. After addressing all the review comments I'll squash the changes into one. The CI is already in a good shape on this :+1: There is just one thing that worries me about these optimizations and is related to theirs fragility: how to ensure that future changes in the journal loading process won't trigger by accident the encoding of the message? That was a major cause of performance issue
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
