clebertsuconic commented on a change in pull request #3036: ARTEMIS-2669
Improve AMQPStandardMessage::reencode on depaging not durable messages
URL: https://github.com/apache/activemq-artemis/pull/3036#discussion_r395682051
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -837,16 +837,26 @@ protected synchronized void
lazyScanAfterReloadPersistence() {
messageDataScanned = MessageDataScanningStatus.SCANNED.code;
modified = false;
+ makeDurable();
+ }
+
+ private void makeDurable() {
+ assert messageDataScanned == MessageDataScanningStatus.SCANNED.code;
// Message state should reflect that is came from persistent storage
which
// can happen when moved to a durable location. We must re-encode here
to
// avoid a subsequent redelivery from suddenly appearing with a durable
header
// tag when the initial delivery did not.
if (!isDurable()) {
Review comment:
@franz1981 I will do the following: mark this as DO-NOT-MERGE-YET... if you
could remove these lines... run the testsuite and see if anything breaks... at
that point you let us know.
I believe this was written as in.. I feel like it should have been durable..
why not set it to durable.. as opposed to it's really breaking anything.
No rush on this.. hence why I'm marking DO-NOT-MERGE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
