clebertsuconic commented on a change in pull request #3036: ARTEMIS-2669
Improve AMQPStandardMessage::reencode on depaging not durable messages
URL: https://github.com/apache/activemq-artemis/pull/3036#discussion_r395795490
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -837,16 +837,26 @@ protected synchronized void
lazyScanAfterReloadPersistence() {
messageDataScanned = MessageDataScanningStatus.SCANNED.code;
modified = false;
+ makeDurable();
+ }
+
+ private void makeDurable() {
+ assert messageDataScanned == MessageDataScanningStatus.SCANNED.code;
// Message state should reflect that is came from persistent storage
which
// can happen when moved to a durable location. We must re-encode here
to
// avoid a subsequent redelivery from suddenly appearing with a durable
header
// tag when the initial delivery did not.
if (!isDurable()) {
Review comment:
just completed a testsuite.. .and I see no need for this re-encoding.
I say lets get rid of this.
@tabish121 do you remember why you added this on
a851a8f93f30972d252f2bff0bb3d5847cfd7b5f ?
if you're ok with removing it... it should be gone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
