clebertsuconic commented on issue #3048: ARTEMIS-1975 Fixing LargeMessage encoding for replication URL: https://github.com/apache/activemq-artemis/pull/3048#issuecomment-603613295 today I have sent two commits directly into master, as I thought they were obvious change that didn't require peer review. in the process I broke org.apache.activemq.artemis.tests.integration.amqp.largemessages.AmqpReplicatedLargeMessageTest this is fixing AmqpReplicatedLargeMessageTest Instead of using a Thread local for the cache of the saved buffer, I'm storing the record on the Message. However for replication, this may be broken due to multi-threading. This is fixing that by adding reference counting. I did some manual testing to make sure there are no leaks. I couldn't find a way to add a permanent test without being invasive in performance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
