franz1981 commented on a change in pull request #3048: ARTEMIS-1975 Fixing
LargeMessage encoding for replication
URL: https://github.com/apache/activemq-artemis/pull/3048#discussion_r397638589
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java
##########
@@ -126,6 +127,20 @@ public void closeLargeMessage() throws Exception {
parsingData = null;
}
+ public synchronized void releaseEncodedBuffer() {
Review comment:
Why synchronized? We perform these operations concurrently?
If the semantic of accesses is as-single-threaded, but is happening on
different Threads one-by-one, is ok to remove the synchronization (and better,
because better document that this class shouldn't be used for concurrent
accesses)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
