franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834 @clebertsuconic I see on `PagedMessageImpl` this check: ```java public boolean isLargeMessage() { return message instanceof ICoreMessage && ((ICoreMessage)message).isLargeMessage(); } ``` and ``` @Override public void encode(final ActiveMQBuffer buffer) { buffer.writeLong(transactionID); boolean isLargeMessage = isLargeMessage(); buffer.writeBoolean(isLargeMessage); ``` why we cannot modify the check/encode/decode to correctly write the `isLargeMessage` prefix field?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services