franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607329180 @clebertsuconic I've tried to come up with a test to cover AMQP large and standard messages: let me know if the way I create and write `AMQPLargeMessage` is wrong. While working on it I've found a test failure on the new test `AmqpPageTest::testLargeMessagePageWithNIO` while checking `Assert.assertEquals(largeMessages ? 1 : 0, pagedMessage.getMessage().getUsage());` I have pushed a change trying to fix this, but maybe the `assert` is just wrong for AMQP, while it's valid only for Core large messages.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
