michaelpearce-gain commented on a change in pull request #3066: ARTEMIS-2699
Warn if queue stats are limited by default maxRows
URL: https://github.com/apache/activemq-artemis/pull/3066#discussion_r404027429
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/StatQueue.java
##########
@@ -156,6 +160,10 @@ private void printStats(String result) {
for (int i = 0; i < array.size(); i++) {
printQueueStats(array.getJsonObject(i));
}
+
+ if (maxRows == null && array.size() == DEFAULT_MAX_ROWS) {
Review comment:
first of all array.size() == DEFAULT_MAX_ROWS seems duff logic, surely if
size > DEFAULT_MAX_ROWS is the logix expected based on the output below.
surely better to have this as if maxRows >= array.size() this way even if
someone sets it to some other value, thats still smaller than array.size then
you want to ouytput that the output has been limited.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
