brusdev commented on a change in pull request #3066: ARTEMIS-2699 Warn if queue
stats are limited by default maxRows
URL: https://github.com/apache/activemq-artemis/pull/3066#discussion_r404065580
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/StatQueue.java
##########
@@ -156,6 +160,10 @@ private void printStats(String result) {
for (int i = 0; i < array.size(); i++) {
printQueueStats(array.getJsonObject(i));
}
+
+ if (maxRows == null && array.size() == DEFAULT_MAX_ROWS) {
Review comment:
The maxRows should always be >= array.size() but I would like to print the
warning only if maxRows is not set by user and array.size() == DEFAULT_MAX_ROWS.
If you call `queue stat` without the parameter `maxRows` then you get at
most 50 queues but you could not know that results are limited by the default
maxRows value.
The purpose of the warning is only to help users that don't know that
default maxRows value is 50.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
