michaelpearce-gain commented on a change in pull request #3066: ARTEMIS-2699
Warn if queue stats are limited by default maxRows
URL: https://github.com/apache/activemq-artemis/pull/3066#discussion_r404102999
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/StatQueue.java
##########
@@ -110,25 +112,27 @@ public Object execute(ActionContext context) throws
Exception {
return null;
}
+ int printingMaxRows = this.maxRows != null ? this.maxRows :
DEFAULT_MAX_ROWS;
Review comment:
but why discriminate? surely just simplify the logic, because if i set 100
but count was 1001 it still be useful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
