michaelpearce-gain commented on a change in pull request #3066: ARTEMIS-2699
Warn if queue stats are limited by default maxRows
URL: https://github.com/apache/activemq-artemis/pull/3066#discussion_r404122820
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/StatQueue.java
##########
@@ -151,11 +155,16 @@ private void printStats(String result) {
}
JsonObject queuesAsJsonObject = JsonUtil.readJsonObject(result);
- JsonArray array = (JsonArray) queuesAsJsonObject.get("data");
+ int count = queuesAsJsonObject.getInt("count");
+ JsonArray array = queuesAsJsonObject.getJsonArray("data");
for (int i = 0; i < array.size(); i++) {
printQueueStats(array.getJsonObject(i));
}
+
+ if (maxRows == null && count > printingMaxRows) {
Review comment:
this isnt a sql query though, its an admin tool, and like you said in sql if
you dont limit you get all, thats not behaviour here, so its not the same at
all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
