jbertram commented on issue #3063: ARTEMIS-2692 refactor queue creation
URL: https://github.com/apache/activemq-artemis/pull/3063#issuecomment-612648027
 
 
   I just pushed these changes:
   
   - Broke the single commit into 2 commits - one for the broker code-base and 
one for the tests. Both commits pass the test-suite indicating no regressions 
(suggested by @michaelandrepearce).
   - Removed `createTemporaryQueue` from the API completely. I did not remove 
`createSharedQueue` because that is going to require some wire-format changes 
and I didn't want to introduce those into these commits (suggested by @Havret).
   - Encapsulated the logic to translate a few packets to a 
`QueueConfiguration` (suggested by @franz1981).
   
   IMO this is ready to be merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to