michaelandrepearce commented on issue #3063: ARTEMIS-2692 refactor queue creation URL: https://github.com/apache/activemq-artemis/pull/3063#issuecomment-613118170 Point to split changing the tests to be in a next release is that honestly i got to about 100ish classes reviewed and ill be honest it became more of a skim review, once i got off the core classes. So id say im 60 % confident in that there isnt an issue. That said and reason for split pr / release is that we all know its not until its released and peoples qa teams run much larger test suites or deploy into pre prod environments that we find the edge cases. By keeping the tests the same makes it easier to check against previous version with a test case and make/edit existing test that shows a regression as same test would work on last release also. That said I've run a full test suite with the first commit and all was good.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
